Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/logging: basic set of tests for bucket logging #576

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

yuvalif
Copy link
Contributor

@yuvalif yuvalif commented Aug 8, 2024

bucket logging is implemented here: ceph/ceph#59808
ceph/ceph#54815

@yuvalif yuvalif added the DNM Do Not Merge label Aug 8, 2024
@yuvalif yuvalif force-pushed the wip-yuval-bucket-logging branch from 6f7c758 to b072edb Compare August 22, 2024 16:33
@yuvalif yuvalif removed the DNM Do Not Merge label Aug 26, 2024
@yuvalif yuvalif force-pushed the wip-yuval-bucket-logging branch from b072edb to 29484fa Compare August 26, 2024 08:59
@yuvalif yuvalif force-pushed the wip-yuval-bucket-logging branch from 29484fa to 0a60c07 Compare September 16, 2024 15:35
@yuvalif
Copy link
Contributor Author

yuvalif commented Sep 19, 2024

missing test:

  • add versioned bucket tests
  • test conf update
  • test LC on log bucket
  • add a separate test suite to cover "Standard" mode even if we have extensions

yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 11, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 14, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 14, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 20, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
@yuvalif yuvalif force-pushed the wip-yuval-bucket-logging branch from a493a21 to b78bdf6 Compare November 21, 2024 14:07
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 21, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
@yuvalif
Copy link
Contributor Author

yuvalif commented Nov 22, 2024

test is passing. see: ceph/ceph#60700 (comment)

@cbodley
Copy link
Contributor

cbodley commented Nov 25, 2024

why is it necessary to duplicate the s3 extensions file from the ceph repo? i'd rather not worry about trying to keep those in sync

@yuvalif
Copy link
Contributor Author

yuvalif commented Nov 25, 2024

why is it necessary to duplicate the s3 extensions file from the ceph repo? i'd rather not worry about trying to keep those in sync

the other (and better) option is to fetch it from the ceph repo, but in my case I had to have a way to fetch it from a branch on my ceph fork.

yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 26, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 26, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 27, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 27, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Nov 27, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Dec 5, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
yuvalif added a commit to yuvalif/ceph that referenced this pull request Dec 5, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

and the bucket logging PR:
ceph#59808

also point to the s3test of bucket logging.
this should be reverted before merging.

Signed-off-by: Yuval Lifshitz <[email protected]>
@yuvalif yuvalif force-pushed the wip-yuval-bucket-logging branch from 877ec17 to 10d46f4 Compare December 5, 2024 20:46
yuvalif added a commit to yuvalif/ceph that referenced this pull request Dec 8, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

Signed-off-by: Yuval Lifshitz <[email protected]>
@cbodley cbodley merged commit 74188c6 into ceph:master Dec 10, 2024
@cbodley
Copy link
Contributor

cbodley commented Dec 10, 2024

cherry-picked to ceph-master

kulahe3 pushed a commit to kulahe3/ceph that referenced this pull request Dec 10, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

Signed-off-by: Yuval Lifshitz <[email protected]>
AliMasarweh pushed a commit to AliMasarweh/ceph that referenced this pull request Dec 11, 2024
this is depended with this s3test PR:
ceph/s3-tests#576

Signed-off-by: Yuval Lifshitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants